From 98f27b0acc19ba0f7e956d862db4f1465114fad1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gerg=C5=91=20M=C3=B3ricz?= <mo.geryy@gmail.com>
Date: Sun, 15 Dec 2024 16:29:09 +0100
Subject: [PATCH] fix(crawl-redis/addCrawlJobDone): further ensure that
 completed doesn't go over total

---
 apps/api/src/lib/crawl-redis.ts | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/apps/api/src/lib/crawl-redis.ts b/apps/api/src/lib/crawl-redis.ts
index 3fcd9f67..0c9e0ff0 100644
--- a/apps/api/src/lib/crawl-redis.ts
+++ b/apps/api/src/lib/crawl-redis.ts
@@ -92,12 +92,16 @@ export async function addCrawlJobDone(
 
   if (success) {
     await redisConnection.rpush("crawl:" + id + ":jobs_done_ordered", job_id);
-    await redisConnection.expire(
-      "crawl:" + id + ":jobs_done_ordered",
-      24 * 60 * 60,
-      "NX",
-    );
+  } else {
+    // in case it's already been pushed, make sure it's removed
+    await redisConnection.lrem("crawl:" + id + ":jobs_done_ordered", -1, job_id);
   }
+  
+  await redisConnection.expire(
+    "crawl:" + id + ":jobs_done_ordered",
+    24 * 60 * 60,
+    "NX",
+  );
 }
 
 export async function getDoneJobsOrderedLength(id: string): Promise<number> {