From 712a138404d0b0fbb2c1d115ab8ac7f22f01e715 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gerg=C5=91=20M=C3=B3ricz?= <mo.geryy@gmail.com>
Date: Wed, 4 Dec 2024 17:47:37 +0100
Subject: [PATCH] fix(crawl-status): hard error bug

---
 apps/api/src/controllers/v1/crawl-status.ts | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/apps/api/src/controllers/v1/crawl-status.ts b/apps/api/src/controllers/v1/crawl-status.ts
index f150ddc4..8493e855 100644
--- a/apps/api/src/controllers/v1/crawl-status.ts
+++ b/apps/api/src/controllers/v1/crawl-status.ts
@@ -5,6 +5,7 @@ import { getScrapeQueue } from "../../services/queue-service";
 import { supabaseGetJobById, supabaseGetJobsById } from "../../lib/supabase-jobs";
 import { configDotenv } from "dotenv";
 import { Job, JobState } from "bullmq";
+import { logger } from "../../lib/logger";
 configDotenv();
 
 export async function getJob(id: string) {
@@ -98,8 +99,12 @@ export async function crawlStatusController(req: RequestWithAuth<CrawlStatusPara
       // both loops will break once we cross the byte counter
       for (let ii = 0; ii < jobs.length && bytes < bytesLimit; ii++) {
         const job = jobs[ii];
+        if (job.returnvalue === undefined) {
+          logger.warn("Job was considered done, but returnvalue is undefined!", { jobId: job.id });
+          continue;
+        }
         doneJobs.push(job);
-        bytes += JSON.stringify(job.returnvalue).length;
+        bytes += JSON.stringify(job.returnvalue ?? null).length;
       }
     }