Iyeoluwads/firecrawl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(scrape): better timeout handling

Browse Source
This commit is contained in:
Móricz Gergő
2024-11-12 13:16:40 +01:00
parent aa9a47bce7
commit 3815d24628
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/api/src/controllers/v0/scrape.ts
+1 -1
View File
@@ -86,7 +86,7 @@ export async function scrapeHelper(
try { try {
doc = (await waitForJob<Document>(jobId, timeout)); doc = (await waitForJob<Document>(jobId, timeout));
} catch (e) { } catch (e) {
if (e instanceof Error && e.message.startsWith("Job wait")) { if (e instanceof Error && (e.message.startsWith("Job wait") || e.message === "timeout")) {
span.setAttribute("timedOut", true); span.setAttribute("timedOut", true);
return { return {
success: false, success: false,
apps/api/src/controllers/v0/search.ts
+1 -1
View File
@@ -196,7 +196,7 @@ export async function searchController(req: Request, res: Response) {
}); });
return res.status(result.returnCode).json(result); return res.status(result.returnCode).json(result);
} catch (error) { } catch (error) {
if (error instanceof Error && error.message.startsWith("Job wait")) { if (error instanceof Error && (error.message.startsWith("Job wait") || error.message === "timeout")) {
return res.status(408).json({ error: "Request timed out" }); return res.status(408).json({ error: "Request timed out" });
} }
apps/api/src/controllers/v1/scrape.ts
+1 -1
View File
@@ -56,7 +56,7 @@ export async function scrapeController(
doc = await waitForJob<Document>(jobId, timeout + totalWait); // TODO: better types for this doc = await waitForJob<Document>(jobId, timeout + totalWait); // TODO: better types for this
} catch (e) { } catch (e) {
logger.error(`Error in scrapeController: ${e}`); logger.error(`Error in scrapeController: ${e}`);
if (e instanceof Error && e.message.startsWith("Job wait")) { if (e instanceof Error && (e.message.startsWith("Job wait") || e.message === "timeout")) {
return res.status(408).json({ return res.status(408).json({
success: false, success: false,
error: "Request timed out", error: "Request timed out",