Iyeoluwads/firecrawl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #648 from mendableai/nsc/fix-json-error-handler

Browse Source 
Fixed 500 errors when JSON is badly formatted
This commit is contained in:
Nicolas
2024-09-09 12:28:18 -03:00
committed by GitHub
parent 60a15d00eb ca9a781eb7
commit 31e973d915
1 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/api/src/index.ts
+11 -7
View File
@@ -201,16 +201,20 @@ if (cluster.isMaster) {
Sentry.setupExpressErrorHandler(app); Sentry.setupExpressErrorHandler(app);
app.use((err: unknown, req: Request<{}, ErrorResponse, undefined>, res: ResponseWithSentry<ErrorResponse>, next: NextFunction) => { app.use((err: unknown, req: Request<{}, ErrorResponse, undefined>, res: ResponseWithSentry<ErrorResponse>, next: NextFunction) => {
if (err instanceof SyntaxError && 'status' in err && err.status === 400 && 'body' in err) {
return res.status(400).json({ success: false, error: 'Bad request, malformed JSON' });
}
const id = res.sentry ?? uuidv4(); const id = res.sentry ?? uuidv4();
let verbose = JSON.stringify(err); let verbose = JSON.stringify(err);
if (verbose === "{}") { if (verbose === "{}") {
if (err instanceof Error) { if (err instanceof Error) {
verbose = JSON.stringify({ verbose = JSON.stringify({
message: err.message, message: err.message,
name: err.name, name: err.name,
stack: err.stack, stack: err.stack,
}); });
} }
} }
Logger.error("Error occurred in request! (" + req.path + ") -- ID " + id + " -- " + verbose); Logger.error("Error occurred in request! (" + req.path + ") -- ID " + id + " -- " + verbose);